Skip to content

Conversation

@wangmengyan95
Copy link
Contributor

Remove gradle.properties and move version to build.gradle.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work or do we need to use project.version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, but let's use project.version.

@wangmengyan95 wangmengyan95 force-pushed the wangmengyan.remove_gradle.properties branch from dc73611 to bdb3cab Compare October 20, 2015 18:37
@grantland grantland assigned wangmengyan95 and unassigned grantland Oct 20, 2015
@grantland
Copy link
Contributor

LGTM!

wangmengyan95 added a commit that referenced this pull request Oct 20, 2015
@wangmengyan95 wangmengyan95 merged commit 350eece into master Oct 20, 2015
@wangmengyan95 wangmengyan95 deleted the wangmengyan.remove_gradle.properties branch October 20, 2015 19:17
@facebook-github-bot
Copy link

@wangmengyan95 updated the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants